Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distinct support in sea-orm #902

Merged
merged 3 commits into from
Sep 25, 2022
Merged

distinct support in sea-orm #902

merged 3 commits into from
Sep 25, 2022

Conversation

kyoto7250
Copy link
Contributor

@kyoto7250 kyoto7250 commented Jul 20, 2022 •
edited
Loading

close #275

Adds

This PR adds distinct methods in helper.rs

  • distinct
  • distinct on (only sqlx-postgres)

@kyoto7250 kyoto7250 marked this pull request as ready for review July 21, 2022 00:44
@kyoto7250 kyoto7250 changed the title distinct support distinct support in sea-orm Jul 21, 2022
billy1624
billy1624 reviewed Jul 25, 2022
View reviewed changes
src/query/helper.rs Outdated Show resolved Hide resolved
billy1624
billy1624 reviewed Jul 25, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kyoto7250, thanks for contributing!! Look pretty good. I've some comments
Please check and see if it make sense.
Thanks!! :)

src/query/helper.rs Outdated Show resolved Hide resolved
src/query/helper.rs Outdated Show resolved Hide resolved
billy1624
billy1624 approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the great contributions! @kyoto7250

@billy1624 billy1624 requested a review from tyt2y3 July 26, 2022 04:30
@billy1624 billy1624 merged commit ba5a83d into SeaQL:master Sep 25, 2022
billy1624 added a commit that referenced this pull request Sep 25, 2022
@billy1624
CHANGELOG (#902)
fbdd3ea
billy1624 added a commit that referenced this pull request Sep 25, 2022
@billy1624
CHANGELOG (#902, #953, #947, #864, #991, #988)
e29a11e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billy1624 billy1624 billy1624 approved these changes

@tyt2y3 tyt2y3 Awaiting requested review from tyt2y3

Assignees

@kyoto7250 kyoto7250

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Distinct support?
2 participants
@kyoto7250 @billy1624